-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config reload]Config Reload Enhancement #2693
Conversation
@dgsudharsan , looks like the PR has an issue, when updating the sonic-utilities for the sonic-buildimage, the build failed, see PR sonic-net/sonic-buildimage#14619, and the build result: https://dev.azure.com/mssonic/build/_build/results?buildId=251574&view=logs&jobId=e2a1d004-6151-514d-dd3b-ba225f574bd9&j=e2a1d004-6151-514d-dd3b-ba225f574bd9&t=84643f3d-b87b-5e33-4d3a-7ffd9da7d441
|
@xumia This is due to a cyclic dependency with buildimage PR and I have updated sonic-buildimage PR with submodule update of sonic-utilities and sonic-host-services sonic-net/sonic-buildimage#13969. Once the above PR is merged you shouldn't see error |
Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" Modified relevant files Added UT to verify
Backporting #2693 What I did Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" How I did it Modified relevant files How to verify it Added UT to verify
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
What I did
Code changes for HLD: sonic-net/SONiC#1203
Removed the timer based checks for config reload
Added db_migrator to migrate from "has_timer" to "delayed"
Modified package-manager to migrate from "has_timer" to "delayed"
How I did it
Modified relevant files
How to verify it
Added UT to verify
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)