[sonic-package-manager] support extension with multiple YANG modules #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
force-pushed
the
multi-yang-support
branch
from
0874860
to
fe14c51
Compare
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
previously approved these changes
Mar 27, 2023
|
Do you have a link to the HLD? I could not understand the motivation "support for application extensions to have multiple YANG modules recorded in the labels". |
|
@qiluo-msft The motivation is to allow 1 application extension provide multiple YANG modules for multiple unrelated CONFIG_DB tables. Such applications is internal work, no public HLD available. |
|
@qiluo-msft If you are saying to update App.Ext HLD then I prepared PR with documents update - sonic-net/SONiC#1321 |
qiluo-msft
previously approved these changes
Apr 14, 2023
|
@qiluo-msft @volodymyrsamotiy @liat-grozovik Request for 202211 (I have no permissions to add labels) |
|
Could you resolve conflict? |
stepanblyschak
dismissed stale reviews from qiluo-msft and volodymyrsamotiy
via
bd613f5
|
@qiluo-msft Done |
|
@volodymyrsamotiy @qiluo-msft kindly reminder to review the code |
qiluo-msft
approved these changes
Apr 30, 2023
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 88ffb167 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778)) * 7443b9e5 [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752)) * 522c3a9e [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753)) * b38fcfd1 [show][muxcable] fix RC ([sonic-net#2812](sonic-net/sonic-utilities#2812)) * 7e24463f [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * bee593e4 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * ada603c5 [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 88a7daa8 [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699)) * 5e99edb5 [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726)) * b547bb45 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added support for application extensions to have multiple YANG modules recorded in the labels.
How I did it
Extended support for yang modules. Preserved backward compatibility with existing extensions.
How to verify it
UT.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)