[sonic-package-manager] add support for multiple CLI plugin files #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
approved these changes
Mar 27, 2023
qiluo-msft
approved these changes
Apr 7, 2023
|
@qiluo-msft @volodymyrsamotiy @liat-grozovik Request for 202211 (I have no permissions to add labels) |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 88ffb167 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778)) * 7443b9e5 [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752)) * 522c3a9e [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753)) * b38fcfd1 [show][muxcable] fix RC ([sonic-net#2812](sonic-net/sonic-utilities#2812)) * 7e24463f [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * bee593e4 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * ada603c5 [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 88a7daa8 [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699)) * 5e99edb5 [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726)) * b547bb45 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
|
Hi @stepanblyschak I found that if we want to add a docker image in sonic-buildimage without providing cli files would encounter error like below while building iamge: I found that failed at manager.py#L991 because the value was set to '' in manifest.json.j2 in sonic-buildimage because cli path is not provided. Not sure if I miss something or cli files for docker image installed by sonic-package-manager are mandatory... Could you pls help to take a look? |
PeterTSW-EC
added a commit
to PeterTSW-EC/sonic-utilities-community
that referenced
this pull request
Jul 16, 2024
… Install * In 17/05/2023, SONiC updates the format of CLI section in the manifest.json. * The implementation was updated in 202311 or later branches. * However, the PR sonic-net#2753 reported there is a error occur when the CLI migration. * The root cause is occurred while a CLI field (show/config/clear) is empty (''). * This PR modifies the parser of the cli_plugins field in the manifest.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Use case for some application extensions we develop is to have multiple features as part of a single container. Therefore we want to have ability to install multiple CLI plugins from a single extension.
How I did it
Allowed to specify few CLI plugins in the manifest.
How to verify it
Build extension with multiple CLI plugins and install. Verified all plugins are installed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)