Modify teamd retry count script to base BGP status on default BGP status #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yxieca
approved these changes
Dec 14, 2023
saiarcot895
added a commit
to saiarcot895/sonic-utilities
that referenced
this pull request
Jan 10, 2024
This backports a part of sonic-net#3069 to allow upgrading from 202205 to 202305 with the teamd retry count feature. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jan 11, 2024
…tus (sonic-net#3069) For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Cherry-pick PR to 202305: #3117 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 11, 2024
…tus (#3069) For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Add teamd retry count script to 202205 image This backports a part of #3069 to allow upgrading from 202205 to 202305 with the teamd retry count feature. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Feb 2, 2024
…tus (sonic-net#3069) For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Cherry-pick PR to 202311: #3145 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
…tus (#3069) For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For each BGP status, if the
admin_statusfield is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in thedefault_bgp_statusfield coming frominit_cfg.json), which is specified during image build. If the default BGP status is up, thenadmin_statuswill be created only when the BGP session is brought down; similarly, if the default BGP status is down, thenadmin_statuswill be created when the BGP session is brought up.How I did it
Because of that, modify the script to use the default BGP status as the initial value.
How to verify it
Tested on KVM and verified that the list of port channels seen were correct in the following cases:
default_bgp_status: down,config load_minigraphdefault_bgp_status: down,config load_minigraph,config bgp startup alldefault_bgp_status: up,config load_minigraphdefault_bgp_status: up,config load_minigraph,config bgp shutdown allPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)