[action] [PR:3069] Modify teamd retry count script to base BGP status on default BGP status (#3069) #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tus (sonic-net#3069) For each BGP status, if the `admin_status` field is not present, then whether the BGP session is admin up or admin down depends on the default BGP status (in the `default_bgp_status` field coming from `init_cfg.json`), which is specified during image build. If the default BGP status is up, then `admin_status` will be created only when the BGP session is brought down; similarly, if the default BGP status is down, then `admin_status` will be created when the BGP session is brought up. Because of that, modify the script to use the default BGP status as the initial value. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Original PR: #3069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each BGP status, if the
admin_statusfield is not present, thenwhether the BGP session is admin up or admin down depends on the default
BGP status (in the
default_bgp_statusfield coming frominit_cfg.json), which is specified during image build. If the defaultBGP status is up, then
admin_statuswill be created only when the BGPsession is brought down; similarly, if the default BGP status is down,
then
admin_statuswill be created when the BGP session is brought up.Because of that, modify the script to use the default BGP status as the
initial value.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com