[filter-fdb] Check VLAN Presence When Filter FDB #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
tahmed-dev
commented
Jun 22, 2020
|
This pull request introduces 2 alerts when merging 4c1b8cc into 5a13e0b - view on LGTM.com new alerts:
|
making lgtm happy Added two more test cases
tahmed-dev
force-pushed
the
taahme/filter-out-invalid-vlans
branch
from
67cec53
to
be445f8
Compare
lguohan
reviewed
Jun 22, 2020
yxieca
approved these changes
Jun 23, 2020
lguohan
approved these changes
Jun 24, 2020
yxieca
pushed a commit
that referenced
this pull request
Jun 24, 2020
* [filter-fdb] Check VLAN Presence When Filter FDB FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * review comments making lgtm happy Added two more test cases * Update existing test case and adding new one * adding support for filter ou based on vlan ip network
|
@tahmed-dev Please create PR for 201911. Cherry-pick has conflict. |
@abdosi, just cherry-picked on my local repo and it did cherry-pick cleanly. Not sure if you have stale branch. Anyways, will post the PR |
tahmed-dev
added a commit
to tahmed-dev/sonic-utilities
that referenced
this pull request
Jul 8, 2020
* [filter-fdb] Check VLAN Presence When Filter FDB FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * review comments making lgtm happy Added two more test cases * Update existing test case and adding new one * adding support for filter ou based on vlan ip network
prsunny
reviewed
Jul 8, 2020
| vlan_cidr = defaultdict() | ||
| if "VLAN_INTERFACE" in config_db_entries.keys() and "VLAN" in config_db_entries.keys(): | ||
| for vlan_key in config_db_entries["VLAN_INTERFACE"].keys(): | ||
| vlan, cidr = tuple(vlan_key.split('|')) |
There was a problem hiding this comment.
Late comment - There could be entry without cidr in config_db. You may want to skip such entries or it may fail. Can you also put those entries in test_vector and verify.
"VLAN_INTERFACE": {
"Vlan1000": {}
},
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
* [filter-fdb] Check VLAN Presence When Filter FDB FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * review comments making lgtm happy Added two more test cases * Update existing test case and adding new one * adding support for filter ou based on vlan ip network
abdosi
pushed a commit
that referenced
this pull request
Aug 9, 2020
* [filter-fdb] Check VLAN Presence When Filter FDB FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * review comments making lgtm happy Added two more test cases * Update existing test case and adding new one * adding support for filter ou based on vlan ip network
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
As part of this commit and previous commit ff6cb6c sonic-utilities submodule for 201911 has been updated to take following changes: Add support for QSFP-DD cables on 'show' command (sonic-net#989) [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) Enable HW watchdog before fast-reboot (sonic-net#977) [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975) [filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976) [show/config]: combine feature and container feature cli (sonic-net#1015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
FTOS fast conversion script generates bogus vlan that does not exist.
This PR uses config_db in order to verify that provided vlans exist
in the switch configuration.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- How I did it
Added new code to parse config_db.json and used this to filter out arp entries
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)