[filter-fdb] Check VLAN Presence When Filter FDB (#957) #975
Conversation
* [filter-fdb] Check VLAN Presence When Filter FDB FTOS fast conversion script generates bogus vlan that does not exist. This PR uses config_db in order to verify that provided vlans exist in the switch configuration. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * review comments making lgtm happy Added two more test cases * Update existing test case and adding new one * adding support for filter ou based on vlan ip network
| vlan_cidr = defaultdict() | ||
| if "VLAN_INTERFACE" in config_db_entries.keys() and "VLAN" in config_db_entries.keys(): | ||
| for vlan_key in config_db_entries["VLAN_INTERFACE"].keys(): | ||
| vlan, cidr = tuple(vlan_key.split('|')) |
There was a problem hiding this comment.
There could be entry without cidr in config_db. You may want to skip such entries or it may fail. Can you also put those entries in test_vector and verify.
"VLAN_INTERFACE": {
"Vlan1000": {}
},
There was a problem hiding this comment.
Good catch. did not know such entries exists. @yxieca FYI... we might want to hold off on .81.
There was a problem hiding this comment.
Actually, these entries exists in 201911 and master. 201811 doesn't have such entries FYI
There was a problem hiding this comment.
@prsunny, is this a bug in these branches! I did not recall seeing them, however when you alerted me, it happened that I had master image on my DUT and I saw it! I created a fix for it. No, I am inclined to know why they exist on master and on 201911. Sounds like a bug there that needs to be addressed.
There was a problem hiding this comment.
it is not a bug, but a feature introduced as part of VRF in 201911 and above
There was a problem hiding this comment.
@tahmed-dev is above comment has been addressed ?
As part of this commit and previous commit ff6cb6c sonic-utilities submodule for 201911 has been updated to take following changes: Add support for QSFP-DD cables on 'show' command (sonic-net#989) [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) Enable HW watchdog before fast-reboot (sonic-net#977) [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975) [filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976) [show/config]: combine feature and container feature cli (sonic-net#1015)
FTOS fast conversion script generates bogus vlan that does not exist.
This PR uses config_db in order to verify that provided vlans exist
in the switch configuration.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
review comments
making lgtm happy
Added two more test cases
Update existing test case and adding new one
adding support for filter ou based on vlan ip network
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)