Support multiple sun position dispatch methods #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
jeanconn
reviewed
Feb 27, 2023
taldcroft
commented
Feb 27, 2023
|
I think this is still a WIP because it probably needs new tests and more details in the description, but I don't know if there are any other issues / challenges. |
jeanconn
force-pushed
the
more-accurate-sun-position
branch
from
dbbee34 to
c8cc287
Compare
jeanconn
changed the title
jeanconn
changed the title
jeanconn
changed the title
|
I've marked this for review by @javierggt as it is @taldcroft 's PR but with some new commits by me at the end. |
|
I individually reviewed each commit from @jeanconn and they all look good. |
|
@jeanconn - I'm just trying to rebase and there are some non-trivial merge conflicts. So stand by (meaning don't try to do this independently). |
taldcroft
force-pushed
the
more-accurate-sun-position
branch
from
5ac26ba to
f6a9915
Compare
|
OK, I just had not pulled the force-pushed remote branch. |
|
Thanks! And yeah, generally I try to refrain from force-pushing somebody-else's branch, but I was just trying to get through to tests passing when I started with this. |
jeanconn
approved these changes
Sep 12, 2023
2 tasks
This was referenced Sep 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The legacy "fast" method of computing the sun RA, Dec from the Earth geocenter appears to have errors up to about 0.3 deg. For many applications this is fine, but for cases where this is not OK this PR adds a new more accurate method which uses the DE432s ephemeris.
Fixes #2.
Interface impacts
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
Added new unit test to do some rough functional testing against data in obsid 17198.