Set to use nominal roll range 0-360 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
jeanconn
commented
Sep 18, 2023
taldcroft
approved these changes
Sep 18, 2023
This was referenced Sep 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set to use nominal roll range 0-360
This restores the behavior before #25
Interface impacts
Changes nominal roll range back to 0-360 from -180 to 180. Unlikely to be impacting for downstream use, but impacts a sparkles test.
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Added new unit test. Confirmed that sparkles tests (including test_roll_options_dec89_9) pass against this PR.