Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mahjong] Add mahjong to Env #1069

Merged
merged 8 commits into from
Oct 28, 2023
Merged

[Mahjong] Add mahjong to Env #1069

merged 8 commits into from
Oct 28, 2023

Conversation

OkanoShinri
Copy link
Collaborator

No description provided.

@OkanoShinri
Copy link
Collaborator Author

Screenshot from 2023-10-18 22-38-06

api_testがしんどそうです……

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1069 (66262ad) into main (2b0f2b7) will increase coverage by 1.13%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   86.90%   88.03%   +1.13%     
==========================================
  Files          54       54              
  Lines        6047     5900     -147     
==========================================
- Hits         5255     5194      -61     
+ Misses        792      706      -86     
Files Coverage Δ
pgx/mahjong/__init__.py 100.00% <100.00%> (ø)
pgx/mahjong/_action.py 100.00% <ø> (ø)
pgx/mahjong/_hand.py 79.24% <100.00%> (ø)
pgx/mahjong/_meld.py 58.02% <100.00%> (ø)
pgx/mahjong/_shanten.py 97.67% <ø> (ø)
pgx/mahjong/_yaku.py 100.00% <100.00%> (ø)
pgx/_src/dwg/mahjong.py 52.31% <90.90%> (ø)
pgx/mahjong/_env.py 94.30% <98.70%> (ø)
pgx/v1.py 70.71% <33.33%> (-0.64%) ⬇️

from .shanten import Shanten
from .yaku import Yaku

__all__ = ["Mahjong", "State", "Action", "Hand", "Yaku", "Shanten"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__all__ = ["Mahjong", "State", "Action", "Hand", "Yaku", "Shanten"]
__all__ = ["Mahjong"]

@sotetsuk
Copy link
Owner

action.py とか __init__.py 以外はすべて最初にアンダーバーをつけてほしい _action.py

@OkanoShinri OkanoShinri requested a review from sotetsuk October 27, 2023 10:28
@sotetsuk
Copy link
Owner

いい感じです!マージしちゃってください! 🙏 @OkanoShinri

@OkanoShinri OkanoShinri merged commit d92baa8 into main Oct 28, 2023
4 checks passed
@OkanoShinri OkanoShinri deleted the okano/feat/mahjong-env branch October 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants