Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chess] Reduce _is_checked call #1231

Merged
merged 7 commits into from
Sep 12, 2024
Merged

[Chess] Reduce _is_checked call #1231

merged 7 commits into from
Sep 12, 2024

Conversation

sotetsuk
Copy link
Owner

@sotetsuk sotetsuk commented Sep 12, 2024

c.f. #1230

fn jaxpr lines time
_legal_action_mask 2467 728.2ms
_flip 92 33.4ms
_is_checked 206 68.8ms
_is_pseudo_legal 136 40.4ms
_hash_castling_en_passant 37 18.5ms
_apply_move 331 107.0ms
_update_history 57 30.9ms

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (8760db1) to head (6106755).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   80.64%   80.58%   -0.06%     
==========================================
  Files          62       62              
  Lines        5967     5950      -17     
==========================================
- Hits         4812     4795      -17     
  Misses       1155     1155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sotetsuk sotetsuk merged commit 0ea0557 into main Sep 12, 2024
5 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/reduce-checked-call branch September 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant