[Hex] Modify visualizer.py to handle TypeError when displaying the initial state of hex. #1261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We cannot visualize the initial state of
hex
.It raises
TypeError: 'int' object is not subscriptable
.Reason
This is caused by the following code in line 396 of visualizer.py.
The current implementation above tries to read
_state._size
, which is int object.Also, python raises
TypeError
, therefore it would not be caught by the exception handlerexcept IndexError:
.Proposal
I propose to convert
_state._size
intoint
via one dimensionaljnp.array
.I think this is stabler because both
int
andjaxlib.xla_extension.ArrayImpl
with one element can be converted toint
.Reproduction of the error
If we run the following code, we get
TypeError: 'int' object is not subscriptable
.Or, this is the screenshot if you prefer.