Use an array as listen attribute instead of a hash #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR amends the logic introduced in sous-chefs#378 to use an array as attribute instead of a hash, as this will simplify using this cookbook in other recipes. E.g., if a recipe wants httpd to listen on `addr:port`, it is much easier to just set node.set['apache2']['listen'] += ['addr:port'] instead of first having to check whether the listen hash does have the key `addr` already and then either add it or update the port list.
|
Any chance we could merge this? The current implementation in master makes it nearly impossible to override the default setting for *:80 and *:443 without using drop on the Mash itself. Additionally the implementation as a Hash leads to chef handling this as a Mash and auto merging all precedences -> meaning you can only override *:80 by setting some other value for the key * (which will always lead to apache listening on * and some port) or dropping it as mentioned above (which is quite ugly). |
|
Yeah, I kind of like this. |
drpebcak
added a commit
that referenced
this pull request
Mar 1, 2016
Use an array as listen attribute instead of a hash
legal90
added a commit
to legal90/chef-stash
that referenced
this pull request
Apr 19, 2016
In cookbook apache2 v3.2.0 the attribute was changed and renamed: `node.default['apache']['listen_ports']` -> `node.default['apache']['listen']` sous-chefs/apache2#409
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends the logic introduced in #378 to use an array as attribute instead of a hash, as this will simplify using this cookbook in other recipes.
E.g., if a recipe wants httpd to listen on
addr:port, it is much easier tojust set
instead of first having to check whether the listen hash does have the
key
addralready and then either add it or update the port list.