Allow overriding UID during user creation #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Tests fail due to |
|
Looks reasonable. What do you think about |
|
sure, will add gid as well |
This is useful when you want to make sure the user has the same UID across all hosts.
shortdudey123
force-pushed
the
allow_user_uid
branch
from
e393afb
to
314ac91
Compare
|
Rebased and added gid |
shortdudey123
force-pushed
the
allow_user_uid
branch
from
314ac91
to
ed02ff7
Compare
shortdudey123
force-pushed
the
allow_user_uid
branch
from
ed02ff7
to
2ccc2da
Compare
|
@mthssdrbrg any follow up thoughts? |
|
@shortdudey123: I changed back to using Thanks for the contribution, and sorry for the late response :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when you want to make sure the user has the same UID across all hosts.
Side note: will rebase once #106 is merged since i assumed that syntax would be used