These changes add in ulimit for file descriptors.

[solarce]

These changes add in ulimit for file descriptors.

For #56

[dpkp]

+1 -- this is a very important config for running in prod.

[mthssdrbrg]

We usually have quite obscene limits on our servers by default, so I haven't even considered this before, but I think it would be a great addition.

However, I feel like this should be an optional setting, thus the default value should be nil and just wrap the lines in the init scripts with an if statement, for the people that would rather use their system defaults.

[solarce]

That makes sense, I'll rework that tonight

[solarce]

I've tested the upstart bit on ubuntu 12.04 and it worked for me

    - update content in file /etc/init/kafka.conf from cf249c to 9715a7
        --- /etc/init/kafka.conf    2014-09-24 16:49:19.891930063 +0000
        +++ /tmp/chef-rendered-template20140924-25305-mtnzbn    2014-09-24 16:50:41.915930069 +0000
        @@ -7,6 +7,7 @@

         kill signal TERM
         kill timeout 10
        +limit nofile 50000 50000
         setuid kafka

         script

[mthssdrbrg]

Cool. I have some other stuff that I'm gonna push to master as soon as I get the time, but I should be able to get this merged before the end of the week.

[mthssdrbrg]

Merged, thanks for the PR.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.