Allow KAFKA_JMX_OPTS to be configured #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the ability to customize the KAFKA_JMX_OPTS environment variable via the default.kafka.jmx_opts attribute. This follows the same pattern as the KAFKA_JVM_PERFORMANCE_OPTS variable.
|
Looks great, thanks a lot! This'll be included in v0.8.0, just waiting for #83. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to customize the
KAFKA_JMX_OPTSenvironment variable via thedefault.kafka.jmx_optsattribute. This follows the same pattern as theKAFKA_JVM_PERFORMANCE_OPTSvariable.I tested this locally with
kitchen testand everything passed.Thanks for the great cookbook and let me know if I missed anything here.