[Merged by Bors] - api: v2alpha1: Use subquery instead of left join for transaction list. #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on test generator.
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
fasmat
approved these changes
Aug 19, 2024
poszu
approved these changes
Aug 19, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
#6269) Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries. Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions. Added CustomQuery field to sql builder to allow more complex expressions. Fixed transaction test generator.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6269 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 307 307
Lines 34105 34106 +1
=========================================
- Hits 27990 27989 -1
+ Misses 4337 4336 -1
- Partials 1778 1781 +3 ☔ View full report in Codecov by Sentry. |
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
kacpersaw
added a commit
that referenced
this pull request
Aug 21, 2024
#6269) Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries. Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions. Added CustomQuery field to sql builder to allow more complex expressions. Fixed transaction test generator.
fasmat
pushed a commit
that referenced
this pull request
Aug 21, 2024
…action list. (#6269) (#6277) * api: v2alpha1: Use subquery instead of left join for transaction list. (#6269) Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries. Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions. Added CustomQuery field to sql builder to allow more complex expressions. Fixed transaction test generator. * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries.
Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions.
Added CustomQuery field to sql builder to allow more complex expressions.
Fixed transaction test generator.