[backport] api: v2alpha1: Use subquery instead of left join for transaction list. (#6269) #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6269) Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries. Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions. Added CustomQuery field to sql builder to allow more complex expressions. Fixed transaction test generator.
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.6 #6277 +/- ##
=======================================
- Coverage 81.7% 81.7% -0.1%
=======================================
Files 301 301
Lines 32306 32285 -21
=======================================
- Hits 26416 26393 -23
Misses 4170 4170
- Partials 1720 1722 +2 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the LEFT JOIN from IterateTransactionsOps because it was too slow for handling queries.
Instead, a subquery with SELECT is used to retrieve tx ids for addresses used in transactions.