This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
IsListening and ownership fix #1246
Merged
aleximprobable
merged 8 commits into
master
from
bugfix/unr-1816-use-static-view-to-check-listening
Jul 31, 2019
Merged
IsListening and ownership fix #1246
aleximprobable
merged 8 commits into
master
from
bugfix/unr-1816-use-static-view-to-check-listening
Jul 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
labels
Jul 30, 2019
m-samiec
reviewed
Jul 30, 2019
improbable-valy
approved these changes
Jul 30, 2019
m-samiec
approved these changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
improbable-prow-robot
added
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
labels
Jul 31, 2019
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
improbable-valy
force-pushed
the
bugfix/unr-1816-use-static-view-to-check-listening
branch
from
July 31, 2019 15:22
b15d52f
to
0d9d169
Compare
improbable-prow-robot
added
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
labels
Jul 31, 2019
aleximprobable
deleted the
bugfix/unr-1816-use-static-view-to-check-listening
branch
July 31, 2019 15:46
m-samiec
pushed a commit
that referenced
this pull request
Aug 7, 2019
* Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated
aleximprobable
pushed a commit
that referenced
this pull request
Aug 7, 2019
* Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated
oblm
added a commit
that referenced
this pull request
Aug 15, 2019
* UNR-1857 Unresolved RPC parameters can cause permanent queue blocking (#1277) * Apply RPC with unresolved refs after it's been queued for a while. * Updated Changelog.md * Moved logic to process RPCs with unresolved references to ApplyRPC function. Added SecondsToProcessRPCWithUnresolvedRefs setting with 1.0 as default value * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Added logging for RPCs processed with unresolved parameters. * Updated CHANGELOG.md * Updated CHANGELOG.md * Fixed a couple of typos * Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Changed SecondsToProcessRPCWithUnresolvedRefs to WaitTimeBeforeProcessingReceivedRPCWithUnresolveRefs, exposed it GDK settings. * Fixed UI issue for a new setting * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Timestamp -> QueuedTimestamp * Renamed WaitTimeBeforeProcessingReceivedRPC_WithUnresolvedRefs -> QueuedIncomingRPCWaitTime, but kept the same DisplayName * Update CHANGELOG.md * IsListening and ownership fix (#1246) (#1284) * Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated * UNR-1864 Use GetPlugin helper method to resolve sim player laun… (#1278) * Used GetPlugin helper method to resolve sim player launch config * Updated changelog * DOC-1255 Clarify elements of the GDK in readme (#1287) * Clarify elements of the GDK * Apply suggestions from code review Co-Authored-By: Laura <36853437+ElleEss@users.noreply.github.com> * Updates from review * Update CHANGELOG.md * Switch validity checks to use whats defaulted (#1300) * Update CHANGELOG.md * Update CHANGELOG.md
aleximprobable
added a commit
that referenced
this pull request
Aug 19, 2019
* UNR-1857 Unresolved RPC parameters can cause permanent queue blocking (#1277) * Apply RPC with unresolved refs after it's been queued for a while. * Updated Changelog.md * Moved logic to process RPCs with unresolved references to ApplyRPC function. Added SecondsToProcessRPCWithUnresolvedRefs setting with 1.0 as default value * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Added logging for RPCs processed with unresolved parameters. * Updated CHANGELOG.md * Updated CHANGELOG.md * Fixed a couple of typos * Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Changed SecondsToProcessRPCWithUnresolvedRefs to WaitTimeBeforeProcessingReceivedRPCWithUnresolveRefs, exposed it GDK settings. * Fixed UI issue for a new setting * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Timestamp -> QueuedTimestamp * Renamed WaitTimeBeforeProcessingReceivedRPC_WithUnresolvedRefs -> QueuedIncomingRPCWaitTime, but kept the same DisplayName * Update CHANGELOG.md * IsListening and ownership fix (#1246) (#1284) * Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated * UNR-1864 Use GetPlugin helper method to resolve sim player laun… (#1278) * Used GetPlugin helper method to resolve sim player launch config * Updated changelog * DOC-1255 Clarify elements of the GDK in readme (#1287) * Clarify elements of the GDK * Apply suggestions from code review Co-Authored-By: Laura <36853437+ElleEss@users.noreply.github.com> * Updates from review * Update CHANGELOG.md * Switch validity checks to use whats defaulted (#1300) * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Changing the way IsListening check is performed for ActorChannel.
Release note
This should fix a bug, when SpatialActorChannel never started listening.
Tests
Testing with Scavengers and ExampleProject.
Documentation
No doc update.
Primary reviewers
@m-samiec @improbable-valentyn