This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
UNR-1942 - Switch validity checks to use whats defaulted #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
m-samiec
changed the title
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1942 |
improbable-prow-robot
added
jira/UNR
and removed
jira/no-ticket
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1942 |
joshuahuburn
approved these changes
Aug 15, 2019
oblm
added a commit
that referenced
this pull request
Aug 15, 2019
* UNR-1857 Unresolved RPC parameters can cause permanent queue blocking (#1277) * Apply RPC with unresolved refs after it's been queued for a while. * Updated Changelog.md * Moved logic to process RPCs with unresolved references to ApplyRPC function. Added SecondsToProcessRPCWithUnresolvedRefs setting with 1.0 as default value * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Added logging for RPCs processed with unresolved parameters. * Updated CHANGELOG.md * Updated CHANGELOG.md * Fixed a couple of typos * Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Changed SecondsToProcessRPCWithUnresolvedRefs to WaitTimeBeforeProcessingReceivedRPCWithUnresolveRefs, exposed it GDK settings. * Fixed UI issue for a new setting * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Timestamp -> QueuedTimestamp * Renamed WaitTimeBeforeProcessingReceivedRPC_WithUnresolvedRefs -> QueuedIncomingRPCWaitTime, but kept the same DisplayName * Update CHANGELOG.md * IsListening and ownership fix (#1246) (#1284) * Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated * UNR-1864 Use GetPlugin helper method to resolve sim player laun… (#1278) * Used GetPlugin helper method to resolve sim player launch config * Updated changelog * DOC-1255 Clarify elements of the GDK in readme (#1287) * Clarify elements of the GDK * Apply suggestions from code review Co-Authored-By: Laura <36853437+ElleEss@users.noreply.github.com> * Updates from review * Update CHANGELOG.md * Switch validity checks to use whats defaulted (#1300) * Update CHANGELOG.md * Update CHANGELOG.md
aleximprobable
added a commit
that referenced
this pull request
Aug 19, 2019
* UNR-1857 Unresolved RPC parameters can cause permanent queue blocking (#1277) * Apply RPC with unresolved refs after it's been queued for a while. * Updated Changelog.md * Moved logic to process RPCs with unresolved references to ApplyRPC function. Added SecondsToProcessRPCWithUnresolvedRefs setting with 1.0 as default value * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Added logging for RPCs processed with unresolved parameters. * Updated CHANGELOG.md * Updated CHANGELOG.md * Fixed a couple of typos * Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Changed SecondsToProcessRPCWithUnresolvedRefs to WaitTimeBeforeProcessingReceivedRPCWithUnresolveRefs, exposed it GDK settings. * Fixed UI issue for a new setting * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Timestamp -> QueuedTimestamp * Renamed WaitTimeBeforeProcessingReceivedRPC_WithUnresolvedRefs -> QueuedIncomingRPCWaitTime, but kept the same DisplayName * Update CHANGELOG.md * IsListening and ownership fix (#1246) (#1284) * Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated * UNR-1864 Use GetPlugin helper method to resolve sim player laun… (#1278) * Used GetPlugin helper method to resolve sim player launch config * Updated changelog * DOC-1255 Clarify elements of the GDK in readme (#1287) * Clarify elements of the GDK * Apply suggestions from code review Co-Authored-By: Laura <36853437+ElleEss@users.noreply.github.com> * Updates from review * Update CHANGELOG.md * Switch validity checks to use whats defaulted (#1300) * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running a cloud deployment within the editor could result in an non-descript "Deployment configuration is not valid" error. This was because the default snapshot and launch config files that are used to populate the window aren't used in the validity checks when running. Switching the validity check to use the same method that populates the window fixes this.
Tests
Ran cloud launch from within the editor
Primary reviewers
@WVerlaek @joshuahuburn