Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

UNR-2243 Fix a crash when applying component data for deleted static subobject #1423

Conversation

improbable-valy
Copy link
Contributor

Description

Fixed a crash that would occur when checking out an entity that deletes a static subobject on rep notify for a replicated variable inside the actor before trying to apply component data for that subobject.

Release note

Fixed a crash upon checking out an actor with a deleted static subobject.

Primary reviewers

@joshuahuburn @oblm

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2243

@improbable-prow-robot improbable-prow-robot added jira/UNR size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Oct 10, 2019
@improbable-valy improbable-valy changed the title Fix a crash when applying component data for deleted static subobject UNR-2243 Fix a crash when applying component data for deleted static subobject Oct 10, 2019
Copy link
Contributor

@joshuahuburn joshuahuburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a fun one

Copy link
Contributor

@oblm oblm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@improbable-valy improbable-valy merged commit 31b8565 into 0.7.0-preview-rc Oct 10, 2019
@improbable-valy improbable-valy deleted the bugfix/UNR-2243-fix-crash-deleted-static-subobject branch October 10, 2019 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira/UNR size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants