This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added downstream compression.
* Initialize internal SpatialActorChannel state in Init function to clean reused channels from pool * Remove whitespace
* Fixed an issue with multicast RPCs being called close to entity creation * Updated Changelog.md
…#1403) * Only use Owner's Spatial position if it is replicated * Updated changelog * Update CHANGELOG.md
#1402) * Create SpatialActorChannel on a dormant actor when receiving component update * Address PR feedback, refactor dormancy wakeup channel creation into a function * Further PR feedback, mostly cosmetic * Apply suggestions from code review * Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialReceiver.cpp * Apply suggestions from code review
…o 0.7.0-preview-rc
* Create SpatialActorChannel on a dormant actor when receiving component update * Address PR feedback, refactor dormancy wakeup channel creation into a function * Further PR feedback, mostly cosmetic * Make refactored function actually return a channel
…1410) * Force SpatialNetworking in CookAndGenerateSchemaCommandlet * Add docs to CookAndGenerateSchemaCommandlet * Add -SkipSchema switch to GenerateSchemaAndSnapshots (so that you can generate snapshots only)
…ending dormancy has a deleted actor (#1413)
Recent changes might have invalidated an old assumption about having a valid GUID in `PreReceiveSpatialUpdate`. Removing the check for now and adding a warning log to have more context in case this causes a crash further down the line.
* Bugfix/UNR-2164 GSM Reception Fix (#1378) * Process GSM-related Ops first * Addressing PR feedback * Cleaned up FindAndDispatchStartupOpsClient function * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Add CHANGELOG entry * Add CHANGELOG entry * Update CHANGELOG.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update CHANGELOG.md
…subobject (#1423) * Fix a crash when applying component data for deleted static subobject * Update CHANGELOG.md * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialActorChannel.cpp
improbable-valy
requested review from
joshuahuburn,
mattyoung-improbable,
aleximprobable and
a team
October 14, 2019 13:43
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
labels
Oct 14, 2019
improbable-valy
changed the title
Merge preview into master
Merge 0.7.0 preview into master
Oct 14, 2019
aleximprobable
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
oblm
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
joshuahuburn
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/L
Denotes a PR that changes 150-299 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Merge the PRs that were merged into
0.7.0-preview-rc
back into master.#1393
#1395
#1394
#1399
#1403
#1402
#1410
#1413
#1423
Primary reviewers
@mattyoung-improbable @joshuahuburn