This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
Feature/UNR-2132 additional endpoint support patch 4.20 #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET upgraded to 4.6.1 to link to new Platform SDK
.NET upgraded to 4.6.1 to link to new Platform SDK
…m:spatialos/UnrealGDK into feature/UNR-2132-china-support-patch-4-20
improbable-danny
requested review from
joshuahuburn,
improbable-valy and
m-samiec
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2132 |
improbable-prow-robot
added
jira/UNR
size/S
|
There exist instances in our code base and documentation where the assumed regions are I advise an audit (crtl - f) of these. |
m-samiec
reviewed
Nov 27, 2019
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Show resolved
Hide resolved
m-samiec
reviewed
Nov 27, 2019
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Nov 27, 2019
...ialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.csproj
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Nov 27, 2019
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Outdated
Show resolved
Hide resolved
oblm
reviewed
Nov 27, 2019
...ialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.csproj
Outdated
Show resolved
Hide resolved
oblm
reviewed
Nov 27, 2019
Co-Authored-By: Oliver Balaam <oliverbalaam@improbable.io>
…m:spatialos/UnrealGDK into feature/UNR-2132-china-support-patch-4-20
…Launcher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
…Launcher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
improbable-prow-robot
added
size/M
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Show resolved
Hide resolved
…Launcher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
…m:spatialos/UnrealGDK into feature/UNR-2132-china-support-patch-4-20
oblm
approved these changes
Nov 28, 2019
Adding endpoint settings to LocalDeploymentManager
…m:spatialos/UnrealGDK into feature/UNR-2132-china-support-patch-4-20
Added some more info China flags
Tabs->spaces Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
joshuahuburn
reviewed
Dec 3, 2019
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Outdated
Show resolved
Hide resolved
m-samiec
reviewed
Dec 3, 2019
SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs
Outdated
Show resolved
Hide resolved
improbable-valy
approved these changes
Dec 3, 2019
+ Changed tabs->spaces + Sorted DeploymentManager includes
…ted DeploymentManager includes
improbable-prow-robot
added
size/L
joshuahuburn
approved these changes
Dec 3, 2019
improbable-danny
added a commit
that referenced
this pull request
Dec 3, 2019
* Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Added release note * Update CHANGELOG.md Co-Authored-By: Oliver Balaam <oliverbalaam@improbable.io> * FIxes from review * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Updating spatial version * Modifying Setup.bat to respect china endpoints Adding endpoint settings to LocalDeploymentManager * Changing china flag to capital * Fixed URL based on the console * Update Setup.bat Fixing whitespace * Apply suggestions from code review + Formatting suggestions Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> Co-Authored-By: Joshua Huburn <31517089+joshuahuburn@users.noreply.github.com> * Update DeploymentLauncher.cs Whitespace fix * Some items from the review * Changed comparison to case-insensitive and using --china to supply argument instead * Adding --China to shell script also * Update CHANGELOG.md Added some more info China flags * Apply suggestions from code review Tabs->spaces Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * Fix spaces * Fixed formatting * Updated spot version
| @@ -22,6 +23,9 @@ internal class DeploymentLauncher | |||
|
|
|||
| private const string CoordinatorWorkerName = "SimulatedPlayerCoordinator"; | |||
|
|
|||
| private const string CHINA_ENDPOINT_URL = "platform-cn-production.api.spatialoschina.com"; | |||
There was a problem hiding this comment.
I'm not 100% sure this is the right endpoint, didi @Helcaraxan confirm this was the one?
There was a problem hiding this comment.
This should have been platform.api.spatialoschina.com. The production environment does not appears in the URL.
oblm
added a commit
that referenced
this pull request
Dec 5, 2019
* Feature/UNR-2132 additional endpoint support patch 4.20 (#1531) * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Added release note * Update CHANGELOG.md Co-Authored-By: Oliver Balaam <oliverbalaam@improbable.io> * FIxes from review * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Updating spatial version * Modifying Setup.bat to respect china endpoints Adding endpoint settings to LocalDeploymentManager * Changing china flag to capital * Fixed URL based on the console * Update Setup.bat Fixing whitespace * Apply suggestions from code review + Formatting suggestions Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> Co-Authored-By: Joshua Huburn <31517089+joshuahuburn@users.noreply.github.com> * Update DeploymentLauncher.cs Whitespace fix * Some items from the review * Changed comparison to case-insensitive and using --china to supply argument instead * Adding --China to shell script also * Update CHANGELOG.md Added some more info China flags * Apply suggestions from code review Tabs->spaces Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * Fix spaces * Fixed formatting * Updated spot version * Update worker SDK ports (#1549) * Feature/update platform endpoint (#1553) * Update worker SDK ports * Updating platform endpoint * Update CHANGELOG.md (#1560) * Fix the third StopDeployments argument (#1563) * Fix the third StopDeployments argument * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs * Update Version and VersionName in SpatialGDK.uplugin (#1562) * Update Version and VersionName in SpatialGDK.uplugin * Update SpatialGDK.uplugin
DW-Sebastien
pushed a commit
to Darewise/UnrealGDK
that referenced
this pull request
Dec 6, 2019
…rotection * Feature/UNR-2132 additional endpoint support patch 4.20 (spatialos#1531) * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Added release note * Update CHANGELOG.md Co-Authored-By: Oliver Balaam <oliverbalaam@improbable.io> * FIxes from review * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Updating spatial version * Modifying Setup.bat to respect china endpoints Adding endpoint settings to LocalDeploymentManager * Changing china flag to capital * Fixed URL based on the console * Update Setup.bat Fixing whitespace * Apply suggestions from code review + Formatting suggestions Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> Co-Authored-By: Joshua Huburn <31517089+joshuahuburn@users.noreply.github.com> * Update DeploymentLauncher.cs Whitespace fix * Some items from the review * Changed comparison to case-insensitive and using --china to supply argument instead * Adding --China to shell script also * Update CHANGELOG.md Added some more info China flags * Apply suggestions from code review Tabs->spaces Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * Fix spaces * Fixed formatting * Updated spot version * Update worker SDK ports (spatialos#1549) * Feature/update platform endpoint (spatialos#1553) * Update worker SDK ports * Updating platform endpoint * Update CHANGELOG.md (spatialos#1560) * Fix the third StopDeployments argument (spatialos#1563) * Fix the third StopDeployments argument * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs * Update Version and VersionName in SpatialGDK.uplugin (spatialos#1562) * Update Version and VersionName in SpatialGDK.uplugin * Update SpatialGDK.uplugin # Conflicts: # CHANGELOG.md
DW-Sebastien
pushed a commit
to Darewise/UnrealGDK
that referenced
this pull request
Dec 11, 2019
…rotection * Feature/UNR-2132 additional endpoint support patch 4.20 (spatialos#1531) * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Adding API endpoints for China. .NET upgraded to 4.6.1 to link to new Platform SDK * Added release note * Update CHANGELOG.md Co-Authored-By: Oliver Balaam <oliverbalaam@improbable.io> * FIxes from review * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Updating spatial version * Modifying Setup.bat to respect china endpoints Adding endpoint settings to LocalDeploymentManager * Changing china flag to capital * Fixed URL based on the console * Update Setup.bat Fixing whitespace * Apply suggestions from code review + Formatting suggestions Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> Co-Authored-By: Joshua Huburn <31517089+joshuahuburn@users.noreply.github.com> * Update DeploymentLauncher.cs Whitespace fix * Some items from the review * Changed comparison to case-insensitive and using --china to supply argument instead * Adding --China to shell script also * Update CHANGELOG.md Added some more info China flags * Apply suggestions from code review Tabs->spaces Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * + Command-line args changed to lowercase + Changed tabs->spaces + Sorted DeploymentManager includes * Fix spaces * Fixed formatting * Updated spot version * Update worker SDK ports (spatialos#1549) * Feature/update platform endpoint (spatialos#1553) * Update worker SDK ports * Updating platform endpoint * Update CHANGELOG.md (spatialos#1560) * Fix the third StopDeployments argument (spatialos#1563) * Fix the third StopDeployments argument * Update SpatialGDK/Build/Programs/Improbable.Unreal.Scripts/DeploymentLauncher/DeploymentLauncher.cs * Update Version and VersionName in SpatialGDK.uplugin (spatialos#1562) * Update Version and VersionName in SpatialGDK.uplugin * Update SpatialGDK.uplugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Adding support for CN endpoint
Release note
Tests
N/A
STRONGLY SUGGESTED: How can this be verified by QA?
Launch a deployment in CN region
Documentation
Not needed
Primary reviewers
@joshuahuburn