Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHINF-886][MS] Fixing a crash caused by the merge into release related to the jira issue. #111

Merged

Conversation

MatthewSandfordImprobable
Copy link
Contributor

@MatthewSandfordImprobable MatthewSandfordImprobable commented Mar 4, 2020

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.


Description

Previously we got the PlayInEditorID inside ConnectToReceptionist by trying to get the NetDriver and take it off that. Issue with that is that the Example project was making the SpatialWorkerConnection->Connect call before PendingNetGame was set resulting in a crash.

USpatialNetDriver* USpatialWorkerConnection::GetSpatialNetDriverChecked() const
{
UNetDriver* NetDriver = GameInstance->GetWorld()->GetNetDriver();

// On the client, the world might not be completely set up.
// in this case we can use the PendingNetGame to get the NetDriver
if (NetDriver == nullptr)
{
	NetDriver = GameInstance->GetWorldContext()->**PendingNetGame**->GetNetDriver();
}

USpatialNetDriver* SpatialNetDriver = Cast<USpatialNetDriver>(NetDriver);
checkf(SpatialNetDriver, TEXT("SpatialNetDriver was invalid while accessing SpatialNetDriver!"));
return SpatialNetDriver;

}

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/CHINF-886

@improbable-prow-robot improbable-prow-robot added jira/CHINF size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Mar 4, 2020
@MatthewSandfordImprobable MatthewSandfordImprobable merged commit 076f9f3 into 0.8.1-preview-rc Mar 4, 2020
@MatthewSandfordImprobable MatthewSandfordImprobable deleted the bugfix/CHINF-886-crash_fix branch March 4, 2020 14:39
oblm added a commit that referenced this pull request Mar 17, 2020
* [UNR-1715][MS] Fix for error messages being deisplayed when character is killed. (#89)

Essentially there is a race on death between the health component being updated and the player controller unpossessing it's character actor.
I have just added a delay as a quick hacky fix so that both updates are recieved.

* Decrementing player count when player disconnects. (#98)

* [UNR-2425][MS] Fixing bug with sim players not moving.

* [UNR-2608][MS] Decrementing player count when player disconnects.

* Revert "[UNR-2425][MS] Fixing bug with sim players not moving."

This reverts commit 3c662ca.

* Fixing none component on Player character. (#100)

The Nameplate component had "Owner no see" enabled which means that the component will not exist for the owner of the actor.
The fix is simply to check the Nameplate component before using it.

# Conflicts:
#	Game/Content/Characters/BP_FPS_Character.uasset

* Merge of MBL-19 (#108)

* MBL-19 Remove some hard coded logics in ADeploymentsPlayerController. (#94)

* MBL-19 Remove some hard coded thing in ADeploymentsPlayerController and keep existing features.

* Update to player controller.

* Removing tryloadfromcommandline as it is unecessary for release.

Co-authored-by: wangxin <raymonwang@improbable.io>

* [CHINF-886][MS] Fixing a crash caused by the merge into release related to the jira issue. (#111)

* [UNR-3041][MS] Addin 14.3 into release (#112)

* Crash fix when hitting cancel button. (#114)

* [UNR-3071][MS] Updating Worker SDK version to 14.5 (#116)

* Readme update: new docs site + maturity guidelines

* More docs links updates

* Update DefaultSpatialGDKSettings.ini

Co-authored-by: MatthewSandfordImprobable <matthewsandford@improbable.io>
Co-authored-by: wangxin <raymonwang@improbable.io>
Co-authored-by: Ernest Oppetit <ernest@improbable.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/CHINF size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants