MBL-19 Remove some hard coded logics in ADeploymentsPlayerController.

[raymonwang]

Remove hard coded locator url in ADeploymentsPlayerController.
Remove hard coded dev auth token in ADeploymentsPlayerController.
Remove some codes which use worker sdk interface directly.
Reuse some functions from USpatialWorkerConnection class.
Dev auth token could be put into command line parameters like -devAuthToken xxxx .

[improbable-prow-robot]

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/MBL-19

[jessicafalk]

added comments, also adding two more people from the GDK team as reviewers.
Please make sure to always add people from the GDK team to your PRs :)

[jessicafalk]

One thing that I just noticed is that we have removed the usage of the timer completely. This means afaics that we will never check whether any deployments got updated. This was important for 2 reasons:

1. A deployment is maybe not ready yet or has already stopped by the time the player queried the deployments. By requesting to get all available deployments every few seconds, we would ensure that the client would get an up-to-date view
2. The PlayerIdentityToken expires after a while. We receive this as the first thing when we query the deployments and then need to wait until the player makes a choice. there is a small chance that the PIT expires in the meantime and the user is not able to connect to the chosen deployment.

[raymonwang]

One thing that I just noticed is that we have removed the usage of the timer completely. This means afaics that we will never check whether any deployments got updated. This was important for 2 reasons:

1. A deployment is maybe not ready yet or has already stopped by the time the player queried the deployments. By requesting to get all available deployments every few seconds, we would ensure that the client would get an up-to-date view
2. The PlayerIdentityToken expires after a while. We receive this as the first thing when we query the deployments and then need to wait until the player makes a choice. there is a small chance that the PIT expires in the meantime and the user is not able to connect to the chosen deployment.

That should be considered, however I feel it not in the scope of this ticket, it is better to create another ticket to track this.

[jessicafalk]

I would agree, if it was a new feature. However, you removed this functionality with this PR, so I do think that it should be in scope of this ticket.

[raymonwang]

I would agree, if it was a new feature. However, you removed this functionality with this PR, so I do think that it should be in scope of this ticket.

The previous logic just refresh LoginToken regularly, however you mentioned that PlayerIdentityToken expires after a while, does that mean we have to run the whole request dev auth flow regularly?

[jessicafalk]

I would need to double-check if it's only the login token or also the PIT (my bad, I did mean the login token in the previous comment) that expires after a while.

The login token definitely does and that's why we would need to refresh and re-populate the deployments list. It also allows us to show the current status of the deployment instead of an out-dated view if the user doesn't choose immediately. What I would like to ask you to do is to add the functionality of refreshing the deployments after a certain amount of second back in as that is pretty useful.

[jessicafalk]

looks much cleaner !