PHPStan Latte level 5 (#173)

* Change action `$param` type to int where possible * Work around efabrica-team/phpstan-latte#396 Ref #141
spaze · Jul 14, 2023 · dad965c · dad965c
2 parents 45373be + c459e04
commit dad965c
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/site/app/Admin/Presenters/ReviewsPresenter.php b/site/app/Admin/Presenters/ReviewsPresenter.php
@@ -24,12 +24,12 @@ public function actionDefault(): void
 	}
 
 
-	public function actionTraining(string $param): void
+	public function actionTraining(int $param): void
 	{
-		$training = $this->trainings->getById((int)$param);
+		$training = $this->trainings->getById($param);
 
 		$this->template->pageTitle = 'Ohlasy na ' . $training->name;
-		$this->template->reviews = $this->trainingReviews->getAllReviews((int)$param);
+		$this->template->reviews = $this->trainingReviews->getAllReviews($param);
 	}
 
 }
diff --git a/site/app/Admin/Presenters/TalksPresenter.php b/site/app/Admin/Presenters/TalksPresenter.php
@@ -49,10 +49,10 @@ public function renderDefault(): void
 	}
 
 
-	public function actionTalk(string $param): void
+	public function actionTalk(int $param): void
 	{
 		try {
-			$this->talk = $this->talks->getById((int)$param);
+			$this->talk = $this->talks->getById($param);
 		} catch (TalkDoesNotExistException $e) {
 			throw new BadRequestException($e->getMessage(), previous: $e);
 		}
@@ -62,10 +62,10 @@ public function actionTalk(string $param): void
 	}
 
 
-	public function actionSlides(string $param): void
+	public function actionSlides(int $param): void
 	{
 		try {
-			$this->talk = $this->talks->getById((int)$param);
+			$this->talk = $this->talks->getById($param);
 			$this->slides = $this->talkSlides->getSlides($this->talk->getId(), $this->talk->getFilenamesTalkId());
 		} catch (ContentTypeException | TalkDoesNotExistException $e) {
 			throw new BadRequestException($e->getMessage(), previous: $e);

diff --git a/site/app/Admin/Presenters/templates/Pulse/passwordsStorages.latte b/site/app/Admin/Presenters/templates/Pulse/passwordsStorages.latte
@@ -82,7 +82,7 @@
 	<tr n:if="$i != 0"><td></td><td><small><a href="#newdisclosure-{$i}"><span>add {$i + 1}. disclosure</span><span class="hidden">cancel adding</span></a></small></td></tr>
 	<tbody id="newdisclosure-{$i}" n:class="$i != 0 ? hidden">
 	{formContainer new}
-		{formContainer $i}
+		{formContainer "$i"}
 			<tr><th>{label disclosure /}</th><td>{input disclosure}</td></tr>
 			<tr><th>{label url /}</th><td>{input url}</td></tr>
 			<tr><th>{label archive /}</th><td>{input archive}</td></tr>

diff --git a/site/app/Admin/Presenters/templates/Talks/slides.latte b/site/app/Admin/Presenters/templates/Talks/slides.latte
@@ -62,7 +62,7 @@
 	{/formContainer}
 	{formContainer new}
 		{for $i = 0; $i < $newCount; $i++}
-			{formContainer $i}
+			{formContainer "$i"}
 				<tbody class="new-slide changed">
 				<tr>
 					<th class="right">Číslo</th>

diff --git a/site/phpstan-latte-templates.neon b/site/phpstan-latte-templates.neon
@@ -2,7 +2,7 @@ parameters:
 	tmpDir: /tmp/phpstan/michalspacek.cz-latte-templates
 	paths:
 		- app
-	level: 4
+	level: 5
 	latte:
 		engineBootstrap: app/PhpStan/latteEngine.php
 		presenterFactoryBootstrap: app/PhpStan/presenterFactory.php