PHPStan Latte $level++

[spaze]

The app is running PHPStan on level 8 for quite some time already (5cc25c4) and now even on level 9 #147, so let's see how far I can bring the Latte extensions.

PHPStan Latte Levels and PRs:

Lnil:

• Analyze Latte templates #51
• PHPStan Latte templates #68

L0:

• Upgrade PHPStan for Latte templates to level 0 #79

L1:

• Upgrade PHPStan for Latte templates to level 1 #71
• Prepare for phpstan-latte Level 1 #128
• phpstan-latte Level 1 #133

L2:

• PHPStan Latte Level 2 #140
• PHPStan latte - level 2 #135

L3:

• Bump PHPStan Latte level to 3 #142

L4:

• Some variables in templates will always exist #171
• Links to actions with never return type throws "Unreachable statement" efabrica-team/phpstan-latte#387
• Template with {form $form throws "Ternary operator condition is always false." efabrica-team/phpstan-latte#388
  I was able to work around the bug by using just one form for both adding something and editing something
• n:href="foo => $bar" throws "Offset 0 on array does not exist" efabrica-team/phpstan-latte#389
• Variable in template used in two actions is true once, false then efabrica-team/phpstan-latte#390
• {include}'d template ignores that {include} params may be different efabrica-team/phpstan-latte#391
• Bump PHPStan templates check to level 4 #143
• 🐛 Display trainings on a venue page again #180
• 🐛 $trainingAction is not always initialized like in the default action #183
• 🐛 Add header icons back to blog post preview #190

L5:

• Form containers with numeric name efabrica-team/phpstan-latte#396
  Worked around it in ff672c9
• PHPStan Latte level 5 #173

L6:

• Bump to PHPStan Latte level 6 #174

L7:

• {capture $link}Foo:bar{/capture} throws "link() expects string" on level 7 efabrica-team/phpstan-latte#398
  Workaround in Progress to PHPStan Latte level 7 #175
• Added support for form fields in containers efabrica-team/phpstan-latte#380
  2 related errors are ignored in PHPStan Latte level 7 #176 2d7735e, better issue linked in Add better link to ignored errors #184:
  • Call to an undefined method Form_5c1ccf4130219ae1b6d2423e3f6af9e6_image_meta|Nette\Forms\Controls\BaseControl::getLabel() efabrica-team/phpstan-latte#400
• Progress to PHPStan Latte level 7 #175
• PHPStan Latte level 7 #176
• 🐛 Use correct field name for Pulse Passwords algorithm #221

L8:

• PHPStan Latte level 8 #177

L9:

• Bump PHPStan Latte templates to Level 9/max #179
• 🐛 Pass a training action, not a name #182
• 🐛 Use an existing TrainingApplication object #214

+ Bleeding Edge:

• "Cannot resolve latte template for action" when setView is used with bleeding edge enabled efabrica-team/phpstan-latte#402
• Enable bleeding edge rules for templates too #185

Some 🐛🐛🐛 discovered later by for example newer versions of the PHPStan Latte extension

• Send UPC-keys-as-text with a method, not a template #189
• Call redirect on presenters #193

[spaze]

[spaze]

Hey @lulco @MartinMystikJonas look I made it to and past the final boss 🦾

Thanks for creating the extension, looking forward to the next releases. If you want, and think it would be useful, feel free to use this code base for some kind of tests, like regression or so. The license allows it but I wanted to be explicit.

The extension helped me to find some buggy code, like for example that I had a form component and a form container sharing the same name. It worked but probably just by coincidence.

[lulco]

Thanks for using our extension! I wish there were more developers using Nette doing it too. Maybe you can share your experiences O:-)

Ad your error - it is corect to use same name for container and control in it. Extension reports it because of its actual implementation which is hacky. We are trying to improve it step by step.

[spaze]

Interesting, having a form container and a field with the same name felt wrong (because of accessing it with $form[foo]) even though it worked, probably because the field is inside the container sharing the same name, not on the same level.

Anyway, this was an easy change, unlike some other refactoring (which should have been done much much earlier but I was lazy and didn't have the right tools available).

[lulco]

Interesting, having a form container and a field with the same name felt wrong (because of accessing it with $form[foo])

This is kind of transformation we have done to make forms work with extension. The original compiled template is different.

Anyway, this was an easy change, unlike some other refactoring (which should have been done much much earlier but I was lazy and didn't have the right tools available).

[spaze]

This is kind of transformation we have done to make forms work with extension. The original compiled template is different.

Good to know this can also be somehow changed!