Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHPStan Latte level 6 #174

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Bump to PHPStan Latte level 6 #174

merged 1 commit into from
Jul 14, 2023

Conversation

spaze
Copy link
Owner

@spaze spaze commented Jul 14, 2023

Oh look this was easy 😅

Ref #141

@spaze spaze self-assigned this Jul 14, 2023
Oh look this was easy.

Ref #141
@spaze spaze force-pushed the spaze/phpstan-latte-level-6 branch from 1af9e4e to bf2cba0 Compare July 14, 2023 21:51
@spaze spaze mentioned this pull request Jul 14, 2023
@spaze spaze merged commit a9d4d8a into main Jul 14, 2023
54 checks passed
@spaze spaze deleted the spaze/phpstan-latte-level-6 branch July 14, 2023 21:57
@lulco
Copy link
Contributor

lulco commented Jul 14, 2023

Time for next level :D

In my case there are these checkpoints:
Level 2 - get it works
Level 5 - more errors
Level 6 - types everywhere
Level 8 - nullable
Level 9 - mixed (unreachable because of ActiveRow)

@spaze
Copy link
Owner Author

spaze commented Jul 14, 2023

Already exploring level 7. Got some 50 errors, some seem duplicated but fixing those is slow because I have to check whether it's me, you, or Latte? If it's not me, is it a bug, or is it me but just holding it wrong?

In most cases I can find a workaround, but guess that doesn't help you much :-)

@lulco
Copy link
Contributor

lulco commented Jul 14, 2023

If you are not sure, create issue :) we can check it too in some spare time. Sometimes it is phpstan itself and you just have to write your code the way to satisfy it.

@spaze
Copy link
Owner Author

spaze commented Jul 14, 2023

Cool, thanks. Let me know if you think I create one too many issues or they're 🐂💩 🤭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants