Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache-1.1 XML template does not match official license texts #2270

Closed
sdheh opened this issue Dec 7, 2023 · 5 comments · Fixed by #2301
Closed

Apache-1.1 XML template does not match official license texts #2270

sdheh opened this issue Dec 7, 2023 · 5 comments · Fixed by #2301
Labels
minor updates to file URL update, notes update, etc.
Milestone

Comments

@sdheh
Copy link

sdheh commented Dec 7, 2023

The Apache-1.1 XML template does not match the following texts:

The mismatch is:
XML template: please see http://www.apache.org/.
Other texts: please see <http://www.apache.org/>.

@sdheh
Copy link
Author

sdheh commented Dec 8, 2023

The title is different too for https://www.apache.org/licenses/LICENSE-1.1

The mismatch is:
XML template: Apache License 1.1
Other text: The Apache Software License, Version 1.1

@jlovejoy
Copy link
Member

as per matching guideline B12 https://spdx.github.io/spdx-spec/v2.3/license-matching-guidelines-and-templates/#b12-license-name-or-title - title text is to be ignored for matching purposes as it is not part of the substantive license text. As such, we don't use alt tags within a titleText tag

I'm fine to update the title in the titleText tag to match to what is says at the Apache Software Foundation link, but it really shouldn't matter.

@jlovejoy
Copy link
Member

looking at #2278 - I'm not sure what the goal is for the additional markup in the optional section at the end? @pmonks - is it to add the < > around the address?

@jlovejoy jlovejoy added this to the 3.23 milestone Dec 19, 2023
@jlovejoy jlovejoy added the minor updates to file URL update, notes update, etc. label Dec 19, 2023
@pmonks
Copy link
Contributor

pmonks commented Dec 20, 2023

is it to add the < > around the address?

@jlovejoy correct - that was one of the discrepancies @sdheh identified in the original description of this issue.

jlovejoy added a commit that referenced this issue Jan 3, 2024
fixes #2270 

Signed-off-by: Jilayne Lovejoy
@jlovejoy
Copy link
Member

jlovejoy commented Jan 3, 2024

ok... did a bit of research here. Long story short, the text should match to the canonical source of the license which is https://www.apache.org/licenses/LICENSE-1.1

I have now made a new PR (easier than editing @pmonks previous one) accordingly. See #2301 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor updates to file URL update, notes update, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants