Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses issue #2270 #2278

Closed
wants to merge 3 commits into from
Closed

Addresses issue #2270 #2278

wants to merge 3 commits into from

Conversation

pmonks
Copy link
Contributor

@pmonks pmonks commented Dec 18, 2023

I believe this PR should address issue #2270, but I'm new to this repository and am unclear what (if any) automated testing exists to exercise it before submitting a PR. My apologies if this is documented somewhere and I didn't find it.

@jlovejoy jlovejoy added this to the 3.23 milestone Dec 19, 2023
@jlovejoy jlovejoy added the XML markup change potential change or addition to XML markup in license label Jan 2, 2024
@jlovejoy
Copy link
Member

jlovejoy commented Jan 2, 2024

@pmonks - as noted in the issue, I don't think it's worth adding markup to the titleText tag and that may be messing things up.

@pmonks pmonks removed their assignment Jan 2, 2024
@pmonks
Copy link
Contributor Author

pmonks commented Jan 2, 2024

@jlovejoy I've just reverted the changes to the <titleText> tag.

@pmonks
Copy link
Contributor Author

pmonks commented Jan 3, 2024

Superceded by PR #2301.

@pmonks pmonks closed this Jan 3, 2024
@pmonks pmonks deleted the issue-2270 branch January 3, 2024 03:43
@swinslow swinslow removed this from the 3.23 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
XML markup change potential change or addition to XML markup in license
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants