-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CvssV4VulnAssessmentRelationship.md and CvssSeverityType.md #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things I noticed.
Also, as a reminder, we'll need to update the severity property range to be CvssSeverityType
, the CvssV2VulnAssessmentRelationship severity type to CvssSeverityType
and the CvssV3VulnAssessmentRelationship severity type to CvssSeverityType
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Signed-off-by: Jeff Schutt <jeff-schutt@users.noreply.github.com> Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo
Signed-off-by: Jeff Schutt <jeff-schutt@users.noreply.github.com>
Initial draft of changes to support CVSS version 4
CC: @rnjudge @tsteenbe @goneall