Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CvssV4VulnAssessmentRelationship.md and CvssSeverityType.md #501

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

jeff-schutt
Copy link
Collaborator

Initial draft of changes to support CVSS version 4

CC: @rnjudge @tsteenbe @goneall

@jeff-schutt jeff-schutt added this to the 3.0-rc2 milestone Sep 28, 2023
@jeff-schutt jeff-schutt marked this pull request as draft September 28, 2023 00:05
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed.

Also, as a reminder, we'll need to update the severity property range to be CvssSeverityType, the CvssV2VulnAssessmentRelationship severity type to CvssSeverityType and the CvssV3VulnAssessmentRelationship severity type to CvssSeverityType

jeff-schutt and others added 3 commits October 4, 2023 11:50
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Signed-off-by: Jeff Schutt <jeff-schutt@users.noreply.github.com>

Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-schutt jeff-schutt marked this pull request as ready for review October 5, 2023 23:16
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator Author

@jeff-schutt jeff-schutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo

model/Security/Classes/CvssV4VulnAssessmentRelationship.md Outdated Show resolved Hide resolved
Signed-off-by: Jeff Schutt <jeff-schutt@users.noreply.github.com>
@rnjudge rnjudge merged commit cc3f2ea into main Oct 11, 2023
1 check passed
@bact bact deleted the support-cvss-version-4 branch August 28, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants