Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove severity property from CvssV2VulnAssessmentRelationship.md #510

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

jeff-schutt
Copy link
Collaborator

@jeff-schutt jeff-schutt commented Oct 5, 2023

In working to resolve #501 (review) I noticed that the CVSS version 2.0 schema does not include a severity property. The changes remove this field from the class.

CC: @goneall @rnjudge @tsteenbe

@jeff-schutt jeff-schutt added this to the 3.0-rc2 milestone Oct 5, 2023
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @jeff-schutt - agree

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Should mention this depends on #513

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnjudge rnjudge merged commit 2a4ae8e into main Oct 11, 2023
1 check passed
@bact bact deleted the CvssV2-updates branch August 28, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants