-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow True/False for query parameters #116
Allow True/False for query parameters #116
Conversation
@cyprien-g thanks for the pull request 😄 Just an idea: if we relax the boolean parsing anyway, what about using lower() to also allow all uppercase values? |
That's a good idea, I've just made the change. |
@@ -131,9 +131,9 @@ def boolean(s): | |||
>>> boolean('false') | |||
False | |||
''' | |||
if s == 'true': | |||
if s.lower() == 'true': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should allow passing None values, i.e. I would check for None to make sure we always get proper ValueError (and not AttributeError).
d14616b
to
41df524
Compare
When do you think this will be released @hjacobs ? |
Allow True/False for query parameters
@traxair I'm on it, but I have to get our CD server (which does the release) working again first 😏 |
Cool! Looking forward to it 😉 |
I think 'True' / 'False' should be allowed for query parameters. And that would also make swagger client like Bravado compatible with connexion (as it send query parameters with a capital letter).