Allow True/False for query parameters #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyprien-g thanks for the pull request 😄 Just an idea: if we relax the boolean parsing anyway, what about using lower() to also allow all uppercase values? |
|
That's a good idea, I've just made the change. |
| @@ -131,9 +131,9 @@ def boolean(s): | |||
| >>> boolean('false') | |||
| False | |||
| ''' | |||
| if s == 'true': | |||
| if s.lower() == 'true': | |||
There was a problem hiding this comment.
IMHO we should allow passing None values, i.e. I would check for None to make sure we always get proper ValueError (and not AttributeError).
cyprien-g
force-pushed
the
allow-True-False-boolean-query
branch
from
d14616b
to
41df524
Compare
|
When do you think this will be released @hjacobs ? |
hjacobs
added a commit
that referenced
this pull request
Jan 5, 2016
Allow True/False for query parameters
|
@traxair I'm on it, but I have to get our CD server (which does the release) working again first 😏 |
|
Cool! Looking forward to it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think 'True' / 'False' should be allowed for query parameters. And that would also make swagger client like Bravado compatible with connexion (as it send query parameters with a capital letter).