[respecDocWriter] electron not closed properly if the document doesn't exist or is not a respec document #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Nov 29, 2016
marcoscaceres
added a commit
that referenced
this pull request
Nov 30, 2016
* develop: v6.1.5 chore(package): update snyk to version 1.21.2 (#980) chore(package): update snyk to version 1.21.1 (#979) fix: kill nightmare if response.code not 200 or doc is not a respec doc (#977) chore(fetch): patch to latest chore(package): update deps chore(CHANGELOG): regenerate fix: allow karma-edge-launcher on local tests (#963) chore(package): update snyk to version 1.20.0 (#974)
This was referenced Jan 31, 2020
This was referenced Sep 27, 2021
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
respecDocWriter, theelectronprocess is not closed when the source provided doesn't return a HTTP 200 (eg. the document doesn't exist) or when the document is not a respec document.That PR kills the process in the 2 use cases above.