Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 5 update #641

Merged
merged 3 commits into from
Mar 27, 2023
Merged

TypeScript 5 update #641

merged 3 commits into from
Mar 27, 2023

Conversation

mauvealerts
Copy link
Contributor

These updates must be done together

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.0.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.9.5...v5.0.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@tsconfig/svelte](https://github.com/tsconfig/bases/tree/HEAD/bases) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/tsconfig/bases/releases)
- [Commits](https://github.com/tsconfig/bases/commits/HEAD/bases)

---
updated-dependencies:
- dependency-name: "@tsconfig/svelte"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@mauvealerts mauvealerts changed the title Typescript 5 update TypeScript 5 update Mar 27, 2023
@mauvealerts
Copy link
Contributor Author

Just removing isolatedModules was insufficient because the base config specifies both isolatedModules and preserveValueImports. That might be fixed by tsconfig/bases#165 (currently removes one but not the other).

I think I found a workaround, though. I'm inclined to merge it for the sake of simpler dependabot operations

@mauvealerts mauvealerts merged commit a9c7277 into spelunky-fyi:main Mar 27, 2023
@mauvealerts mauvealerts deleted the ts5 branch April 10, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant