Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) remove preserveValueImports & isolatedModules from svelte.json #165

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

dummdidumm
Copy link
Contributor

It's deprecated, too
Leftover from #161

@dummdidumm dummdidumm changed the title (fix) remove preserverValueImports from svelte.json (fix) remove preserveValueImports from svelte.json Mar 27, 2023
@mauvealerts
Copy link

Maybe remove isolatedModules too? I'd make a separate PR, but it'd probably conflict.

@dummdidumm
Copy link
Contributor Author

dummdidumm commented Mar 27, 2023

You're right, isolatedModules is not deprecated but redundant.

@acidoxee
Copy link
Contributor

My bad for leaving that deprecated preserveValueImports option in my PR 🤦‍♂️

Not sure for isolatedModules though @mauvealerts. I don't know anything about Svelte, does it force usage of tsc to build stuff? If not, possible usage of other compilers would require that setting to be present.

@dummdidumm dummdidumm changed the title (fix) remove preserveValueImports from svelte.json (fix) remove preserveValueImports & isolatedModules from svelte.json Mar 27, 2023
@dummdidumm
Copy link
Contributor Author

According to the PR that introduced the verbatimModuleSyntax, isolatedModules is redundant and tsc will throw an error when it encounters it.

@acidoxee
Copy link
Contributor

I was not aware of that, and it's not mentioned in the (upcoming) tsconfig docs in microsoft/TypeScript-Website#2759. I also don't remember seeing errors in my own codebase when using both those flags during the TS v5 beta and RC, is that new? 🤔

@dummdidumm
Copy link
Contributor Author

This test indicated that it throws an error.

@orta
Copy link
Member

orta commented Mar 27, 2023

👍🏻

@orta orta merged commit 7db25a4 into tsconfig:main Mar 27, 2023
@dummdidumm dummdidumm deleted the patch-1 branch March 27, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants