Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users of uncommitted data in Data Store #1219

Closed
soininen opened this issue Feb 12, 2021 · 0 comments
Closed

Warn users of uncommitted data in Data Store #1219

soininen opened this issue Feb 12, 2021 · 0 comments
Assignees
@PiispaH
Labels
enhancement Enhancement of existing feature good first issue Good for newcomers
Milestone
v0.8.0

Comments

@soininen
Copy link
Contributor

As discussed in #1218, users could be warned if their databases contain uncommitted data. One idea was that Data Store's exclamation mark could be used for this purpose.
@soininen soininen added the enhancement Enhancement of existing feature label Feb 12, 2021
@soininen soininen added this to the V0.6 milestone Mar 5, 2021
@ptsavol ptsavol modified the milestones: V0.6, V0.7 Aug 13, 2021
@soininen soininen mentioned this issue Sep 15, 2021
Closed
@soininen soininen added the good first issue Good for newcomers label Feb 9, 2023
@jkiviluo jkiviluo modified the milestones: V0.7, V0.8 May 19, 2023
@PiispaH PiispaH self-assigned this Nov 14, 2023
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Dec 8, 2023
Warn about uncommitted changes with Data Store notification
dd5b7dd 
Now when a db map has uncommitted changes, all Data Stores
that share that same db map will show a notification about
the dirtiness of that Data Store. Edge cases that should
now be covered (and come to mind...):

- If more than one DS points to the same db map, all DSs
pointing to that should be notified if the db map is dirty.
- Everything should still work after renaming a DS

Re spine-tools/Spine-Toolbox#1219
PiispaH pushed a commit that referenced this issue Dec 8, 2023
Warn about uncommitted changes with Data Store notification
9c31709 
Now when a db map has uncommitted changes, all Data Stores
that share that same db map will show a notification about
the dirtiness of that Data Store. Edge cases that should
now be covered (and come to mind...):

- If more than one DS points to the same db map, all DSs
pointing to that should be notified if the db map is dirty.
- Everything should still work after renaming a DS

Re #1219
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Dec 12, 2023
Fix tests
4ba27e6 
Re spine-tools/Spine-Toolbox#1219
This was referenced Dec 12, 2023
Merged
Merged
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Dec 12, 2023
Use temporary requirements for tests
00beabb 
Re spine-tools/Spine-Toolbox#1219
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Dec 18, 2023
Fix notification check for a Data Store without a db map
af0f35d 
Re spine-tools/Spine-Toolbox#1219
PiispaH pushed a commit that referenced this issue Dec 19, 2023
Fix a bug that caused tests to fail
5e7b906 
Re #1219
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Apr 12, 2024
Move test
0e3d2f3 
Re spine-tools/Spine-Toolbox#1219
PiispaH pushed a commit that referenced this issue Apr 12, 2024
Update docs about uncommitted changes
5f9aa0c 
Re #1219
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Apr 12, 2024
Back to default requirements
daa2f82 
Re spine-tools/Spine-Toolbox#1219
@PiispaH PiispaH closed this as completed Apr 12, 2024
PiispaH pushed a commit to spine-tools/spine-items that referenced this issue Apr 15, 2024
Fix DBs not opening
1ea1f1f 
Re spine-tools/Spine-Toolbox#1219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiispaH PiispaH

Labels
enhancement Enhancement of existing feature good first issue Good for newcomers
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
4 participants
@soininen @jkiviluo @ptsavol @PiispaH