Issue 1219 warn of uncommitted DS #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2023 12:03
Now when a db map has uncommitted changes, all Data Stores that share that same db map will show a notification about the dirtiness of that Data Store. Edge cases that should now be covered (and come to mind...): - If more than one DS points to the same db map, all DSs pointing to that should be notified if the db map is dirty. - Everything should still work after renaming a DS Re spine-tools/Spine-Toolbox#1219
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #177 +/- ##
===========================================
+ Coverage 61.68% 61.70% +0.02%
===========================================
Files 190 190
Lines 17655 17683 +28
Branches 2890 2896 +6
===========================================
+ Hits 10890 10912 +22
- Misses 6183 6187 +4
- Partials 582 584 +2 ☔ View full report in Codecov by Sentry. |
added 4 commits
December 18, 2023 12:38
# Conflicts: # requirements.txt # spine_items/data_store/data_store.py # tests/data_store/test_dataStore.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re spine-tools/Spine-Toolbox#2459
Fixes spine-tools/Spine-Toolbox#1219
Checklist before merging