Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling database update keeps opening new dialogs #2915

Closed
soininen opened this issue Aug 9, 2024 · 0 comments · Fixed by spine-tools/spine-items#224 or #2916
Closed

Canceling database update keeps opening new dialogs #2915

soininen opened this issue Aug 9, 2024 · 0 comments · Fixed by spine-tools/spine-items#224 or #2916
Assignees
Labels
bug Something isn't working

Comments

@soininen
Copy link
Contributor

soininen commented Aug 9, 2024

If you click the the Cancel button on Incompatible database version dialog there is a high chance the dialog pops up again.

@soininen soininen added the bug Something isn't working label Aug 9, 2024
@soininen soininen self-assigned this Aug 9, 2024
soininen added a commit that referenced this issue Aug 9, 2024
There would be more than one upgrade dialog per database at project
loading if the dialogs were cancelled. The dialogs would pop up
also when closing a project. This happens no more since DB manager
now keeps tabs on which database has shown the dialog. We ask
for upgrade again only when user tries to open an outdated database
in DB editor.

Re #2915
soininen added a commit to spine-tools/spine-items that referenced this issue Aug 9, 2024
Data Store was blindly using its URL in tear_down() even though
you can close the project in Toolbox without fully specifying it.

Re spine-tools/Spine-Toolbox#2915
soininen added a commit to spine-tools/spine-items that referenced this issue Aug 9, 2024
Don't try to use an incomplete URL when constructing a Data Store.
This is a plausible situation when project is saved and closed before
the database URL is fully defined.

Re spine-tools/Spine-Toolbox#2915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant