Fix constructing a Data Store with incomplete URL #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data Store was blindly using its URL in tear_down() even though you can close the project in Toolbox without fully specifying it. Re spine-tools/Spine-Toolbox#2915
Don't try to use an incomplete URL when constructing a Data Store. This is a plausible situation when project is saved and closed before the database URL is fully defined. Re spine-tools/Spine-Toolbox#2915
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 62.43% 62.39% -0.04%
==========================================
Files 168 168
Lines 17856 17858 +2
Branches 2993 2994 +1
==========================================
- Hits 11148 11143 -5
- Misses 6098 6102 +4
- Partials 610 613 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wonky behavior when project was saved and closed without properly defining a Data Store's URL.
Fixes spine-tools/Spine-Toolbox#2915
Checklist before merging