feat(helm): Allow downloading of Helm repo index using a Helm account #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2020
ethanfrogers
requested review from
german-muzquiz
and removed request for
ethanfrogers
robzienert
reviewed
Sep 15, 2020
| @@ -52,6 +57,10 @@ | |||
| public InputStream download(Artifact artifact) throws IOException { | |||
| InputStream index = downloadIndex(); | |||
|
|
|||
| if (artifact.getType().equals("helm/index")) { | |||
There was a problem hiding this comment.
Should be "helm/index".equals(artifact.getType()), unless you're certain type is nonnull?
german-muzquiz
approved these changes
Sep 18, 2020
jcavanagh
force-pushed
the
helm-watcher-upstream
branch
from
537d228
to
688f617
Compare
|
No reason to risk the NPE - I've swapped the order. Thanks! |
robzienert
approved these changes
Sep 23, 2020
kevinawoo
added a commit
to armory-io/clouddriver
that referenced
this pull request
Sep 25, 2020
…ods-collections-limit * upstream/master: (96 commits) feat(extensibility): Use ExceptionSummaryService in DefaultOrchestrationProcessor to provide custom user messages on exceptions (spinnaker#4929) feat(sql): Add additional dynamic config for event cleanup agent (spinnaker#4934) fix(titus): Update Kato task status to surface better error message (spinnaker#4933) fix(saga): Support for multiple atomic operations in a single task (spinnaker#4931) fix(sql): Test pollution (spinnaker#4928) fix(sql): Add config for limiting amount of aggregate cleanup (spinnaker#4927) feat(security/credentials): AccountCredentials as kork/Credentials (spinnaker#4907) chore(dependencies): Autobump korkVersion (spinnaker#4926) chore(scattergather): Removing unused scattergather module (spinnaker#4925) chore(aws): Remove clouddriver-elasticsearch-aws (spinnaker#4923) feat(helm): Allow downloading of Helm repo index using a Helm account (spinnaker#4773) fix(core): Use a random UUID for saga identifiers rather than task id/requestId (spinnaker#4921) fix(titus): `DeleteServerGroupEvent` should use server group name rather than job id (spinnaker#4922) fix(titus): Add desiredPercentage support for enable/disable server group operation (spinnaker#4914) chore(java11): Target Java 11 (spinnaker#4919) fix(titus): `user` shouldn't be flagged as @nonnull (spinnaker#4920) feat(titus): Wrap `DestroyTitusJob` and `DestroyTitusServerGroup` operations in simple sagas (spinnaker#4916) chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#4918) fix(aws): Fixing launch template flag (spinnaker#4917) fix(event): Force cleanup agent to compare ints (spinnaker#4915) ...
kevinawoo
added a commit
to armory-io/clouddriver
that referenced
this pull request
Sep 25, 2020
…ods-collections-limit * upstream/master: (96 commits) feat(extensibility): Use ExceptionSummaryService in DefaultOrchestrationProcessor to provide custom user messages on exceptions (spinnaker#4929) feat(sql): Add additional dynamic config for event cleanup agent (spinnaker#4934) fix(titus): Update Kato task status to surface better error message (spinnaker#4933) fix(saga): Support for multiple atomic operations in a single task (spinnaker#4931) fix(sql): Test pollution (spinnaker#4928) fix(sql): Add config for limiting amount of aggregate cleanup (spinnaker#4927) feat(security/credentials): AccountCredentials as kork/Credentials (spinnaker#4907) chore(dependencies): Autobump korkVersion (spinnaker#4926) chore(scattergather): Removing unused scattergather module (spinnaker#4925) chore(aws): Remove clouddriver-elasticsearch-aws (spinnaker#4923) feat(helm): Allow downloading of Helm repo index using a Helm account (spinnaker#4773) fix(core): Use a random UUID for saga identifiers rather than task id/requestId (spinnaker#4921) fix(titus): `DeleteServerGroupEvent` should use server group name rather than job id (spinnaker#4922) fix(titus): Add desiredPercentage support for enable/disable server group operation (spinnaker#4914) chore(java11): Target Java 11 (spinnaker#4919) fix(titus): `user` shouldn't be flagged as @nonnull (spinnaker#4920) feat(titus): Wrap `DestroyTitusJob` and `DestroyTitusServerGroup` operations in simple sagas (spinnaker#4916) chore(dependencies): Autobump spinnakerGradleVersion (spinnaker#4918) fix(aws): Fixing launch template flag (spinnaker#4917) fix(event): Force cleanup agent to compare ints (spinnaker#4915) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue: spinnaker/spinnaker#4447
Related PRs:
spinnaker/echo#988
spinnaker/igor#829
spinnaker/deck#8475