Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Add Helm pipeline triggering #988

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

jcavanagh
Copy link
Contributor

@jcavanagh jcavanagh commented Aug 6, 2020

  • Helm trigger event handler
  • Semver checks against chart information

Relates to issue: spinnaker/spinnaker#4447

Related PRs:
spinnaker/igor#829
spinnaker/deck#8475
spinnaker/clouddriver#4773

Copy link
Member

@robzienert robzienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

- Helm trigger event handler
- Semver checks against chart information
@jcavanagh
Copy link
Contributor Author

@robzienert Good point - I've added some tests.

@ethanfrogers ethanfrogers requested review from german-muzquiz and removed request for ethanfrogers September 14, 2020 19:26
@robzienert robzienert added the ready to merge Approved and ready for merge label Sep 15, 2020
@mergify mergify bot added the auto merged label Sep 15, 2020
@mergify mergify bot merged commit 5f81ffa into spinnaker:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants