feat(gce): support resourceManagerTags in instance template #10146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
changed the title
christosarvanitis
approved these changes
Sep 24, 2024
link108
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
resourceManagerTagsin GCE. For more details, refer to: https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates/insert.Enable Resource Manager Tags in the configuration of Deploy stages for the Google provider in GCE.
When setting up a GCE deployment, the resource-manager-tags input option can be found under the Advanced settings.
Resource manager tags must have the following structure:
tagKeys/xxxxxxxxandtagValues/xxxxxxxand resource tags needs to be created before add them to the GCE cluster.The resourceManagerTags are added in the cluster info:
Once the deployment is successful, the resourceManagerTags will be attached to both the InstanceTemplate and the Instance in GCE:
Clouddriver PR: spinnaker/clouddriver#6282
Kork PR: spinnaker/kork#1203
Issue related: spinnaker/spinnaker#6931