feat(gce): support resourceManagerTags in instance template #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
… with the api-client.
|
I published a snapshot version of these changes to upgrade clouddriver and verify everything works as expected |
jasonmcintosh
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
I'd love more tests or SOME Tests around GcsSecretEngine... but.. we don't today :( and it's a library upgrade with the API change to the SecretEngine being internal, there IS a risk of downstream services having to do the same thing, but that should be caught via compile time updates. My ask would be post this we make sure anything ELSE using any of the google libraries ALSO gets updated, aka the clouddriver PR and Halyard (and maybe Orca).
|
I tested with clouddriver and I only see the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
resourceManagerTagsin GCE. See: https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates/insertThese changes upgrade the version of
google-api-services-computeandgoogle-api-client.Issue related: spinnaker/spinnaker#6931