feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).
This was referenced Dec 14, 2023
jasonmcintosh
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Nice! There's some thought long term that... we have a lot of "feature flags", should move some of the concepts into Kork and maybe generic it all so
feature.<service>.flagName kinda properties could be consistent across services. Be a nice enhancement later.
| Map<String, Object> getBuildStatusWithJobQueryParameter( | ||
| @NotNull @Path("buildNumber") Integer buildNumber, | ||
| @NotNull @Path("master") String master, | ||
| @NotNull @Query(value = "job") String job); |
There was a problem hiding this comment.
ONLY call out is... encoding. Calling out the caution on the other PR, but ... not sure how much of an issue that really is. IF job should be URL encoded due to any kinda characters - I don't THINK so at this point though.
|
@Mergifyio backport release-1.28.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…1373) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…1373) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…1373) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d)
This was referenced Jan 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…1373) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
…1373) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d)
mergify bot
added a commit
that referenced
this pull request
Feb 13, 2024
…1373) (#1381) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d) Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Feb 13, 2024
…1373) (#1382) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d) Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
jasonmcintosh
pushed a commit
that referenced
this pull request
Mar 14, 2024
…1373) (#1380) - Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables. - Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail. - Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter). (cherry picked from commit 18d038d) Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When defining a Jenkins job in a sub-folder, the path contains slashes. Consequently, the Spring framework is not capable of accurately matching the request.
Problem
The trigger request fails because it is attempting to initiate a job that is not found.
Solution
A feature flag has been added. This flag influences if we should call the existing endpoint (which accepts the job name as a path variable) or the new one (which accepts the job name as a query parameter).
Before
After
Related PR's
Orca: spinnaker/orca#4618
Igor: spinnaker/igor#1204