Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jenkins): Enable Jenkins job triggers for jobs in sub-folders #1204

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

ciurescuraul
Copy link
Contributor

@ciurescuraul ciurescuraul commented Dec 14, 2023

Description

When defining a Jenkins job in a sub-folder, the path contains slashes. Consequently, the Spring framework is not capable of accurately matching the request.

Problem

The trigger request fails because it is attempting to initiate a job that is not found.

Solution

A feature flag has been added. This flag influences if we should call the existing endpoint (which accepts the job name as a path variable) or the new one (which accepts the job name as a query parameter).

Before

image

After

image

Related PR's

Orca: spinnaker/orca#4618
Echo: spinnaker/echo#1373

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).
Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (only question from others is encoding, but think this'll work pretty well)

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Dec 22, 2023
@mergify mergify bot added the auto merged label Dec 22, 2023
@mergify mergify bot merged commit 54fbbcc into spinnaker:master Dec 22, 2023
4 checks passed
@ovidiupopa07
Copy link
Contributor

@Mergifyio backport release-1.28.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x

Copy link
Contributor

mergify bot commented Jan 22, 2024

backport release-1.28.x release-1.30.x release-1.31.x release-1.32.x release-1.33.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2024
…1204)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
…1204)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
…1204)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
…1204)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)
mergify bot pushed a commit that referenced this pull request Jan 22, 2024
…1204)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)
mergify bot added a commit that referenced this pull request Jan 22, 2024
…1204) (#1216)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)

Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 22, 2024
…1204) (#1215)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)

Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 22, 2024
…1204) (#1214)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)

Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jan 22, 2024
…1204) (#1217)

- Allow triggering of Jenkins jobs that reside in sub-folders, by treating job names containing slashes as query variables.

- Prior to this feature, jobs in sub-folders were not appropriately matched by the Spring framework due to slashes in their path, causing trigger requests to fail.

- Include a new feature flag to determine the usage of the existing endpoint (which uses the job name as a path variable) or an updated endpoint (which takes the job name as a query parameter).

Co-authored-by: Jason <mcintoshj@gmail.com>
(cherry picked from commit 54fbbcc)

Co-authored-by: Raul Cristian <24556350+ciurescuraul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants