Skip to content

Commit

Permalink
fix(core): RetrofitError thrown on login (#1737)
Browse files Browse the repository at this point in the history
This fixes a regression from when PermissionService was converted from
Groovy to Java. Ideally, we'd remove the extra parameter from
FiatService directly, but that requires patching Fiat first, something
that'll be easier to do when we migrate to the monorepo.
  • Loading branch information
jvz authored Nov 15, 2023
1 parent d240baa commit 5f73a67
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ public void login(final String userId) {
try {
AuthenticatedRequest.allowAnonymous(
() -> {
getFiatServiceForLogin().loginUser(userId, null);
// TODO(jvz): FiatService::loginUser should have only one parameter as Retrofit no
// longer requires this body parameter
getFiatServiceForLogin().loginUser(userId, "");
permissionEvaluator.invalidatePermission(userId);
return null;
});
Expand Down

0 comments on commit 5f73a67

Please sign in to comment.