fix(core): RetrofitError thrown on login #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression from when PermissionService was converted from Groovy to Java. Ideally, we'd remove the extra parameter from FiatService directly, but that requires patching Fiat first, something that'll be easier to do when we migrate to the monorepo.
dbyron-sf
approved these changes
Nov 15, 2023
|
@Mergifyio backport release-1.32.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
This fixes a regression from when PermissionService was converted from Groovy to Java. Ideally, we'd remove the extra parameter from FiatService directly, but that requires patching Fiat first, something that'll be easier to do when we migrate to the monorepo. (cherry picked from commit 5f73a67)
mergify bot
added a commit
that referenced
this pull request
Mar 25, 2024
This fixes a regression from when PermissionService was converted from Groovy to Java. Ideally, we'd remove the extra parameter from FiatService directly, but that requires patching Fiat first, something that'll be easier to do when we migrate to the monorepo. (cherry picked from commit 5f73a67) Co-authored-by: Matt Sicker <msicker@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from when PermissionService was converted from Groovy to Java. Ideally, we'd remove the extra parameter from FiatService directly, but that requires patching Fiat first, something that'll be easier to do when we migrate to the monorepo.
Fixes #6887.