Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PermissionService.java #1731

Closed

Conversation

echeng-BC
Copy link

fiat login service does not accept null as a valid Body param.
Issue was introduced in a refactor from groovy to java file.

Related Issue:
spinnaker/spinnaker#6887

fiat login service does not accept null as a valid Body param.
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 9c9798c: Update PermissionService.java

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@echeng-BC echeng-BC closed this Nov 7, 2023
@wooseung-sim
Copy link

@echeng-BC Why this PR has been closed?

@jvz
Copy link
Contributor

jvz commented Nov 15, 2023

I think you can re-open this PR. If I file one, it's going to be nearly the same as this but with an added TODO comment about deleting the parameter from FiatService later (which would be done in the Fiat repo).

@jvz
Copy link
Contributor

jvz commented Nov 15, 2023

Alright re-filed as #1737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants