Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

fix: change way of checking if profile is an OID to use regex #112

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

omrozowicz-splunk
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #112 (8b508e6) into develop (4526b0c) will increase coverage by 0.57%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #112      +/-   ##
===========================================
+ Coverage    58.15%   58.73%   +0.57%     
===========================================
  Files           30       30              
  Lines         1281     1299      +18     
===========================================
+ Hits           745      763      +18     
  Misses         536      536              
Impacted Files Coverage Δ
splunk_connect_for_snmp_poller/manager/tasks.py 36.23% <0.00%> (ø)
..._connect_for_snmp_poller/manager/task_utilities.py 22.56% <100.00%> (+0.91%) ⬆️
tests/test_task_utilities.py 97.10% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff7b00...8b508e6. Read the comment docs.

Copy link
Contributor

@weliasz weliasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little comments.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Expected release notes (by @omrozowicz-splunk)

features:
enrich data with linked tables (#101) (75bdb13)
extract enricher data from config (#97) (123864f)
extract IF-MIB data from an SNMPWALK (#96) (7699591)
support polling the same IP address using multiple profiles (#92) (a6320ca)

fixes:
update regex (8b508e6)
change way of checking if profile is an OID to use regex, add unit tests (11e7501)
mongo real time data check (#107) (4526b0c)
change the way of creating host name which is an id in the database (#104) (bbf2733)
forced commit for creating new release (f3081c1)

others (will not be included in Semantic-Release notes):
delete noqa comment (2af84ae)
update severity threshold for snyk to "high" (#113) (7540a5b)
pre-commit autoupdate [ci skip] (6ff7b00)
pre-commit and debug statements [ci skip] (bb5e0ff)
set threshold for jscdp linter (#105) (c01fb4d)
1.5.0-develop.3 (7306e5d)
fix of duplicated code linter problem (c855088)
fix shellcheck (2fa415a)
apply mypy and flake8 (ec32122)
apply pre-commit isort (9c906f9)
exclude json files from copyright check (f3d6b2d)
update README to include pre-commit (cd6a9eb)
apply pre-commit black (c53b8b6)
pre-commit (9a24536)
33acbbf feat: Replace multiple SNMP walks with one SNMP Bulk (#100)
ebe3ebf Feature/redo walk (#95)
d5879c5 Stubs for lint
9cff184 Stubs for lint
adddbea Stubs for lint
5dc1549 Stubs for lint
2c5a5c3 Feat/multiple profiles2 (#93)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@omrozowicz-splunk omrozowicz-splunk merged commit 277a050 into develop Sep 7, 2021
@omrozowicz-splunk omrozowicz-splunk deleted the fix/profile-name-check branch September 7, 2021 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 1.5.0-develop.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants